GitHub Issue #159: Require all assay transform scripts to reside in container's @scripts dir - #7895
Merged
Conversation
labkey-klum
approved these changes
Jul 30, 2026
3 tasks
cnathe
added a commit
to LabKey/testAutomation
that referenced
this pull request
Jul 31, 2026
…ontainer's @scripts dir (#3133) ## Rationale LabKey/internal-issues#159 Assay transform scripts configured through the designer must now live in the design's own container `@scripts` directory (writable only by platform developers), enforced by a new validateScriptLocation() in the save path, with a site-wide deprecated feature flag as an escape hatch and a usage metric approximating how many existing designs are non-compliant. The Selenium page object switches the default addTransformScript(File) to file-upload mode, deleting any same-named leftover from `@scripts` first. ## Related Pull Requests - LabKey/platform#7895 - #3133 - LabKey/limsModules#2369 ## Changes - Selenium test updates to use file upload for addTransformScript - addTransformScript to check for and remove file from `@scripts` if it already exists
labkey-tchad
pushed a commit
to LabKey/testAutomation
that referenced
this pull request
Jul 31, 2026
…ontainer's @scripts dir (#3133) ## Rationale LabKey/internal-issues#159 Assay transform scripts configured through the designer must now live in the design's own container `@scripts` directory (writable only by platform developers), enforced by a new validateScriptLocation() in the save path, with a site-wide deprecated feature flag as an escape hatch and a usage metric approximating how many existing designs are non-compliant. The Selenium page object switches the default addTransformScript(File) to file-upload mode, deleting any same-named leftover from `@scripts` first. ## Related Pull Requests - LabKey/platform#7895 - #3133 - LabKey/limsModules#2369 ## Changes - Selenium test updates to use file upload for addTransformScript - addTransformScript to check for and remove file from `@scripts` if it already exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/159
Assay transform scripts configured through the designer must now live in the design's own container
@scriptsdirectory (writable only by platform developers), enforced by a new validateScriptLocation() in the save path, with a site-wide deprecated feature flag as an escape hatch and a usage metric approximating how many existing designs are non-compliant. The Selenium page object switches the default addTransformScript(File) to file-upload mode, deleting any same-named leftover from@scriptsfirst.Related Pull Requests
Changes